Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite entity pipe character in JsonEntityId #411

Conversation

mariussoutier
Copy link
Collaborator

Unfortunately cannot test if entity actually starts up. entityRef.tell(Command()) also works when name is illegal.

@mariussoutier mariussoutier requested a review from an-tex November 27, 2024 14:59
@an-tex
Copy link
Owner

an-tex commented Nov 28, 2024

Unfortunately cannot test if entity actually starts up. entityRef.tell(Command()) also works when name is illegal.

did you try an EventSourced entity? I think this issue only arises there (when trying to recover)

@an-tex
Copy link
Owner

an-tex commented Dec 2, 2024

Unfortunately cannot test if entity actually starts up. entityRef.tell(Command()) also works when name is illegal.

did you try an EventSourced entity? I think this issue only arises there (when trying to recover)

@mariussoutier in this case it's easiest to test it using the net.sc8s.akka.components.testkit.ClusterComponentTestKitSpec in the akka-components-testkit module. I've added an example in bd925e1 feel free to change/extend it

the tests in net.sc8s.akka.components.ClusterComponentSpec are mainly for wiring/compilation testing. but it's not really a running actorsystem

@mariussoutier
Copy link
Collaborator Author

I've added an example in bd925e1 feel free to change/extend it

I've played around with it and I think it's enough to test it.

@an-tex an-tex merged commit a907d1a into an-tex:main Dec 4, 2024
2 checks passed
@an-tex
Copy link
Owner

an-tex commented Dec 4, 2024

thx @mariussoutier !

@mariussoutier mariussoutier deleted the rewrite-entity-pipe-character-in-user-codec-instead-of-entity-ref branch December 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants