Skip to content

Commit

Permalink
Fix static library regex check
Browse files Browse the repository at this point in the history
The current regular expression doesn't take into account that the
package version might contain a ".a" as part of the vendor version, for
example, vXX.amznX.
Explicitly check for strings that end with ".a" by adding a $.

Signed-off-by: Gal Pressman <[email protected]>
  • Loading branch information
gal-pressman committed Sep 18, 2019
1 parent 8c1fd76 commit dd1093a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion buildlib/check-build
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ def test_static_libs(args):
with inDirectory(libd):
fns = set(fn for fn in os.listdir(".") if not os.path.islink(fn))
for static_lib in fns:
g = re.match(r"lib(.+)\.a", static_lib)
g = re.match(r"lib(.+)\.a$", static_lib)
if g:
for shared_lib in fns:
if re.match(r"lib%s.*\.so" % (g.group(1)), shared_lib):
Expand Down

0 comments on commit dd1093a

Please sign in to comment.