Issue 940: update mpreal.h #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #940 by replacing mpreal.h for both Brutus and Adaptb, updating Brutus to compile with newer compilers (
using namespace std;is a bad idea because the namespace may gain new members over time that conflict with your code, as happened here in C++17), and fixes a C/C++ symbol confusion problem when linking Brutus.I tried it out with the simple gravity simulation from
examples/textbook/gravity_minimal.pyand it works, except that adaptb doesn't implement some of the methods, but that is what it is given that it's deprecated anyway. At least they compile and run again.