-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup the repo #54
Merged
cleanup the repo #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also adds some comments and documentation.
this removes a clone in `explore`.
this also hides `edit::Editor.buffer`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just some random cleanup of the repo, typos, commenting unwraps, refactoring, ...
crate structure
before
after
full changelog
Table::to_msg
nu::value::mutate_value_cell
returnOption
nu::value::Table
nu::value::transpose
config::parsing
config::parsing::try_color
not publictry_fg_bg_colors
if invalid pathConfig::from_value
config/mod.rs
repr_key
fromconfig
tohandler
src/tui/
value: &Value
inConfig::from_value
app::Mode
app::Mode
Default
foredit::Editor
navigation
an implementation ofapp::App
handle_key_events
an impl ofapp::App
app::App
nuon::from_nuon
from createnuon
crate fromfrom nuon
andto nuon
nushell/nushell#12553