Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo.lock #35

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Add cargo.lock #35

merged 1 commit into from
Mar 8, 2024

Conversation

Lykos153
Copy link
Contributor

@Lykos153 Lykos153 commented Mar 4, 2024

It is recommended for executables to check in the lock file into verison control in order to provide deterministic builds[1]. A missing lock file prevents the project from being built via Nix as well (which is what I was trying to do).

[1] https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control

Fixes #34

It is recommended for executables to check in the lock file into verison
control in order to provide deterministic builds.

https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control

Fixes amtoine#34
Copy link
Owner

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that looks good 🙏

@amtoine amtoine merged commit bda263e into amtoine:main Mar 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why no cargo.lock file?
2 participants