Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the CI in scripts #36

Closed
wants to merge 2 commits into from
Closed

refactor the CI in scripts #36

wants to merge 2 commits into from

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Oct 24, 2023

related to

well, that's basically the exact same thing as in nushell/nupm#37 😉

@amtoine amtoine requested a review from melMass October 24, 2023 16:43
@amtoine amtoine added the ci Something related to the Continuous Integration label Oct 24, 2023
@melMass
Copy link
Collaborator

melMass commented Oct 25, 2023

Nice, I like the idea, I have the exact same comments as the linked PR 😋 !
Why not use nu?
I'm currently exploring that path myself, a combo of justfile and nu scripts for CIs

@amtoine
Copy link
Owner Author

amtoine commented Oct 25, 2023

this is to use the latest revision of Nushell, but i'm wondering if we could just use the latest stable release and upgrade once in a while when the language breaks 🤔

@amtoine
Copy link
Owner Author

amtoine commented Oct 25, 2023

i'll try that in another PR

@amtoine amtoine mentioned this pull request Oct 25, 2023
Merged
@melMass
Copy link
Collaborator

melMass commented Oct 25, 2023

this is to use the latest revision of Nushell, but i'm wondering if we could just use the latest stable release and upgrade once in a while when the language breaks 🤔

I think we mentionned that but I'm more enclined to target release than nightly in general

@amtoine
Copy link
Owner Author

amtoine commented Oct 25, 2023

I think we mentionned that but I'm more enclined to target release than nightly in general

we can bring that question back to the table the day the CI using stable releases fails 😉

@melMass
Copy link
Collaborator

melMass commented Oct 27, 2023

I'm not sure to understand all the CI PRs but I think we can close this in favor of #37

@melMass melMass closed this Oct 27, 2023
@amtoine amtoine deleted the refactor-ci-in-scripts branch October 28, 2023 11:32
amtoine added a commit that referenced this pull request Oct 30, 2023
@amtoine
use the latest stable version of Nushell in the CI (#37)
b361bf4 
might supersede:
- #36

related to
- hustcer/setup-nu#58

## description
this is an experiment to see if that could work without pulling Nightly.
there is an [open issue in the GitHub
action](hustcer/setup-nu#58) for that 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melMass melMass Awaiting requested review from melMass

Assignees
No one assigned
Labels
ci Something related to the Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amtoine @melMass