Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkout back when good or bad are invalid in gm repo bisect #165

Merged
merged 2 commits into from
Jan 25, 2024
Merged

checkout back when good or bad are invalid in gm repo bisect #165

merged 2 commits into from
Jan 25, 2024

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Jan 22, 2024 •
edited
Loading

this PR makes sure the user get back to where they were before running gm repo bisect, i.e.

  • when the --good revision is not good
  • when the --bad revision is not bad
  • when the bisect runs properly, it should start on the same revision as before the good / bad checks

@amtoine
checkout back after checking good and bad
f8a0d53 
this is in case one of the revision is "bad", ensuring the user will be
at the same place they were before running `gm repo bisect`.
@amtoine
rename res to is_good for clarity
925b351
@amtoine amtoine added enhancement New feature or request sugar Related to the `nu-git-manager-sugar` module labels Jan 22, 2024
@amtoine amtoine marked this pull request as ready for review January 25, 2024 18:50
@amtoine amtoine merged commit d1ecc77 into main Jan 25, 2024
5 checks passed
@amtoine amtoine deleted the gm-repo-bisect branch January 25, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request sugar Related to the `nu-git-manager-sugar` module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amtoine