Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to 0.5.0 #159

Merged
merged 10 commits into from
Jan 21, 2024
Merged

bump to 0.5.0 #159

merged 10 commits into from
Jan 21, 2024

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Jan 21, 2024

Note

git diff nightly

correctly gives

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9fc71c9..57437cb 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -13,10 +13,10 @@ jobs:
   tests:
     uses: ./.github/workflows/nupm-tests.yml
     with:
-      nu_version: "0.88.1"
-      nupm_revision: "6a9618fa21453bca4000ac33707b7aace0da35c7"
+      nu_version: "0.89.0"
+      nupm_revision: "66e2eaa848e3f72c1b4a841f26f4dc7efc4fedb9"
 
   documentation:
     uses: ./.github/workflows/check-documentation.yml
     with:
-      nu_version: "0.88.1"
+      nu_version: "0.89.0"
diff --git a/pkgs/nu-git-manager-sugar/nupm.nuon b/pkgs/nu-git-manager-sugar/nupm.nuon
index 974b12f..bee1672 100644
--- a/pkgs/nu-git-manager-sugar/nupm.nuon
+++ b/pkgs/nu-git-manager-sugar/nupm.nuon
@@ -1,6 +1,6 @@
 {
     name: "nu-git-manager-sugar"
-    version: 0.4.0
+    version: 0.5.0
     description: "A collection of extra Nushell tools to manage `git` repositories."
     documentation: "https://github.com/amtoine/nu-git-manager/blob/main/README.md"
     maintainers: [
@@ -9,7 +9,7 @@
     ]
     license: "https://github.com/amtoine/nu-git-manager/blob/main/LICENSE"
     dependencies: {
-        nushell: 0.88.1
+        nushell: 0.89.0
         git: 2.40.1
         optionals: {
             "sugar gh": {
diff --git a/pkgs/nu-git-manager/nupm.nuon b/pkgs/nu-git-manager/nupm.nuon
index e17af38..9fa9895 100644
--- a/pkgs/nu-git-manager/nupm.nuon
+++ b/pkgs/nu-git-manager/nupm.nuon
@@ -1,6 +1,6 @@
 {
     name: "nu-git-manager"
-    version: 0.4.0
+    version: 0.5.0
     description: "A collection of Nushell tools to manage `git` repositories."
     documentation: "https://github.com/amtoine/nu-git-manager/blob/main/README.md"
     maintainers: [
@@ -9,7 +9,7 @@
     ]
     license: "https://github.com/amtoine/nu-git-manager/blob/main/LICENSE"
     dependencies: {
-        nushell: 0.88.1
+        nushell: 0.89.0
         git: 2.40.1
     }
     type: "module"

amtoine and others added 9 commits January 21, 2024 09:19
@amtoine
rename package.nuon to nupm.nuon (#141)
ea1991c 
related to
- nushell/nupm#51

## description
this PR renames the `package.nuon` files to `nupm.nuon` as per
nushell/nupm#51.
@amtoine
fix the export of modules (#134)
f359ced 
depends on
- nushell/nushell#11157
- nushell/nupm#47
- #140
- #141

## description
as directory modules won't export the modules next to any `mod.nu`, this
PR adds `export module` calls to `nu-git-manager-sugar` and the tests,
making the source base compatible again with
nushell/nushell#11157 and
nushell/nupm#47.
@amtoine
fix module exports (#147)
123ee54 
follow-up to
- #134

## description
- `toolkit.nu` still contained `./src/`
- there was a bad `./src/nu-git-manager/mod.nu` introduced by
#134
@amtoine
refactor internal modules (#149)
f233e49 
should
- close #85
 
## description
### before
```
pkgs/nu-git-manager/
|-- nu-git-manager
|   |-- completions
|   |   `-- nu-complete.nu
|   |-- error
|   |   `-- error.nu
|   |-- fs
|   |   |-- cache.nu
|   |   |-- dir.nu
|   |   |-- path.nu
|   |   `-- store.nu
|   |-- git
|   |   |-- repo.nu
|   |   `-- url.nu
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- gm.nu
    `-- mod.nu
```
```
pkgs/nu-git-manager-sugar/
|-- nu-git-manager-sugar
|   |-- completions
|   |   `-- nu-complete.nu
|   |-- extra.nu
|   |-- git
|   |   |-- lib
|   |   |   |-- lib.nu
|   |   |   |-- prompt.nu
|   |   |   `-- style.nu
|   |   |-- mod.nu
|   |   `-- prompt.nu
|   |-- github.nu
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- git.nu
    `-- mod.nu
```

### after
> **Important**
>  caveats:
> - `[1]`: has `use path.nu ...` instead of `use path`
> - `[2]`: has `use style.nu ...` instead of `use style`

```
pkgs/nu-git-manager/
|-- nu-git-manager
|   |-- completions.nu    # internal
|   |-- error.nu          # internal
|   |-- fs                # internal
|   |   |-- cache.nu   [1]
|   |   |-- dir.nu     [1]
|   |   |-- mod.nu
|   |   |-- path.nu
|   |   `-- store.nu   [1]
|   |-- git               # internal
|   |   |-- mod.nu
|   |   |-- repo.nu
|   |   `-- url.nu
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- gm.nu
    `-- mod.nu
```
```
pkgs/nu-git-manager-sugar/
|-- nu-git-manager-sugar
|   |-- completions.nu        # internal
|   |-- extra.nu              # public
|   |-- git                   # public
|   |   |-- lib               #     internal
|   |   |   |-- git.nu     [2]#         public
|   |   |   |-- mod.nu
|   |   |   |-- prompt.nu     #         public
|   |   |   `-- style.nu   [2]#         public
|   |   |-- mod.nu
|   |   `-- prompt.nu         #     public
|   |-- github.nu             # public
|   `-- mod.nu
|-- nupm.nuon
`-- tests
    |-- git.nu
    `-- mod.nu
```

## TODO
- [x] `nu-git-manager-sugar/git/lib` issue with `prompt.nu` in
77596ff
@amtoine
remove deprecated --switch: bool (#154)
a660163 
related to
- nushell/nushell#11365

## description
this PR will suppress the deprecation warning from
nushell/nushell#11365 which is deprecating `:
bool` annotations for switches
@amtoine
fix spreading of arguments to externals (#156)
6ca2a44 
related to
- nushell/nushell#11289

wait for
- nushell/nupm#57
@amtoine
bump NGM to 0.5.0
4d27ff4
@amtoine
bump Nushell to 0.89.0
08c231f
@amtoine
bump Nupm to latest revision
6a80c06 
this includes nushell/nupm#57
@amtoine amtoine added the dev Related to the dev experience label Jan 21, 2024
@amtoine amtoine mentioned this pull request Jan 21, 2024
Closed
@amtoine amtoine merged commit ba3a88d into main Jan 21, 2024
5 checks passed
@amtoine amtoine deleted the bump branch January 21, 2024 08:34
@amtoine amtoine mentioned this pull request Jan 22, 2024
Merged
amtoine added a commit that referenced this pull request Jan 22, 2024
@amtoine
fix the Nushell version in the README (#162)
625dc10 
the bump to Nushell 0.89.0 in
#159 missed the one in the
README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev Related to the dev experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amtoine