Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated --switch: bool #154

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Dec 23, 2023

related to

description

this PR will suppress the deprecation warning from nushell/nushell#11365 which is deprecating : bool annotations for switches

@amtoine amtoine added fix A fix for a bug nightly A bleeding edge change labels Dec 23, 2023
amtoine added a commit to nushell/nupm that referenced this pull request Dec 23, 2023
related to
- nushell/nushell#11365
- amtoine/nu-git-manager#154

## description
this PR will suppress the deprecation warning from
nushell/nushell#11365 which is deprecating `:
bool` annotations for switches.

this didn't break anything but did show a bunch of spurious deprecation
warnings in CI for instance:
https://github.com/amtoine/nu-git-manager/actions/runs/7307569422/job/19913395508#step:6:17
@amtoine amtoine merged commit 3d970c5 into nightly Dec 23, 2023
4 checks passed
@amtoine amtoine deleted the fix-deprecated-bool-annotation branch December 23, 2023 10:15
amtoine added a commit that referenced this pull request Jan 21, 2024
related to
- nushell/nushell#11365

## description
this PR will suppress the deprecation warning from
nushell/nushell#11365 which is deprecating `:
bool` annotations for switches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug nightly A bleeding edge change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant