Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the toolkit in the CI #135

Merged
merged 1 commit into from
Dec 15, 2023
Merged

use the toolkit in the CI #135

merged 1 commit into from
Dec 15, 2023

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Dec 12, 2023

this PR uses the toolkit module and its test command to run the tests in the CI, such that we have only one point to change to modify how the tests run.

@amtoine amtoine added ci Something related to the Continuous Integration dev Related to the dev experience labels Dec 12, 2023
@amtoine amtoine marked this pull request as ready for review December 15, 2023 15:04
@amtoine amtoine merged commit 6d2d176 into main Dec 15, 2023
5 checks passed
@amtoine amtoine deleted the use-toolkit-in-ci branch December 15, 2023 15:05
amtoine added a commit that referenced this pull request Dec 15, 2023
this should fix the CI of #140 thanks to #135.
@amtoine amtoine mentioned this pull request Dec 15, 2023
1 task
amtoine added a commit that referenced this pull request Dec 15, 2023
this PR
- bumps Nushell to `0.88.1`
- bumps Nupm to
nushell/nupm@6a9618f
and nushell/nupm#50

## full changelog
- move the `src/nu-git-manager/` module to
`pkgs/nu-git-manager/nu-git-manager/`
- move the `src/nu-git-manager-sugar/` module to
`pkgs/nu-git-manager/nu-git-manager-sugar/`
- split `package.nuon` into `pkgs/nu-git-manager/package.nuon` and
`pkgs/nu-git-manager-sugar/package.nuon
- fix all the imports, especially in the tests
- fix the `install-package` test of `nu-git-manager`
- clone the `install-package` test from `nu-git-manager` to
`nu-git-manager-sugar`
- fix the listing of modules in the toolkit

## TODO
- [x] fix the CI => #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Something related to the Continuous Integration dev Related to the dev experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant