fix nightly types (#160)

amtoine · Jan 21, 2024 · 8b01fff · 8b01fff
1 parent 471c7fb
commit 8b01fff
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/pkgs/nu-git-manager/nu-git-manager/git/url.nu b/pkgs/nu-git-manager/nu-git-manager/git/url.nu
@@ -28,8 +28,8 @@ export def parse-git-url []: string -> record<host: string, owner: string, group
             }
 
             {
-                owner: $owner,
-                group: $group,
+                owner: ($owner | default ""),
+                group: ($group | default ""),
                 repo: ($tokens | last)
             }
         }

diff --git a/pkgs/nu-git-manager/nu-git-manager/mod.nu b/pkgs/nu-git-manager/nu-git-manager/mod.nu
@@ -114,7 +114,7 @@ export def "gm clone" [
         }
     }
 
-    let urls = get-fetch-push-urls $repository $fetch $push $ssh
+    let urls = get-fetch-push-urls $repository ($fetch | default "") ($push | default "") $ssh
 
     mut args = [$urls.fetch $local_path --origin $remote]
     if $depth != null {

diff --git a/pkgs/nu-git-manager/tests/mod.nu b/pkgs/nu-git-manager/tests/mod.nu
@@ -45,15 +45,15 @@ export def git-url-parsing [] {
     let cases = [
         [input, host, owner, group, repo];
 
-        ["https://github.com/foo/bar",                  "github.com", "foo", null,      "bar"],
-        ["https://github.com/foo/bar.git",              "github.com", "foo", null,      "bar"],
-        ["https://github.com/foo/bar/tree/branch/file", "github.com", "foo", null,      "bar"],
-        ["ssh://github.com/foo/bar",                    "github.com", "foo", null,      "bar"],
-        ["[email protected]:foo/bar",                      "github.com", "foo", null,      "bar"],
-        ["https://gitlab.com/foo/bar",                  "gitlab.com", "foo", null,      "bar"],
-        ["[email protected]:foo/bar",                      "gitlab.com", "foo", null,      "bar"],
+        ["https://github.com/foo/bar",                  "github.com", "foo",        "", "bar"],
+        ["https://github.com/foo/bar.git",              "github.com", "foo",        "", "bar"],
+        ["https://github.com/foo/bar/tree/branch/file", "github.com", "foo",        "", "bar"],
+        ["ssh://github.com/foo/bar",                    "github.com", "foo",        "", "bar"],
+        ["[email protected]:foo/bar",                      "github.com", "foo",        "", "bar"],
+        ["https://gitlab.com/foo/bar",                  "gitlab.com", "foo",        "", "bar"],
+        ["[email protected]:foo/bar",                      "gitlab.com", "foo",        "", "bar"],
         ["[email protected]:foo/bar/baz/brr",              "gitlab.com", "foo", "bar/baz", "brr"],
-        ["git://git.suckless.org/st",             "git.suckless.org",  null, null,      "st"],
+        ["git://git.suckless.org/st",             "git.suckless.org",    "",        "",  "st"],
     ]
 
     for case in $cases {
@@ -204,7 +204,7 @@ export def cache-manipulation [] {
         root_hash: "",
     }
 
-    def "assert cache" [cache: list<string>]: nothing -> nothing {
+    def "assert cache" [cache: list<any>]: nothing -> nothing {
         let actual = open-cache $CACHE | update path { path remove-prefix (pwd | path sanitize) }
         let expected = $cache
             | each {|it|