add more owners.yaml files

[erwinmombay]

No description provided.

[donttrustthisbot]

/to @cramforce

[erwinmombay]

I'd like to have a secondary owner for these sub directories since the single owner's are also usually the ones sending PR's for reviews

this is also a bug that i currently don't handle in the owner project code, if an OWNER file only has a single entry and also the Pull Request author it should not be eligible and should traverse up for a reviewer list.

[cramforce]

Can I see how the check looks in github anywhere?

[erwinmombay]

@cramforce do you mean status checks to block a PR from being merge-able? currently working on that

[cramforce]

@erwinmombay that is what I meant. You will need a little logo :)

[erwinmombay]

@cramforce the main issue im running into is that the "approvals" endpoint or data is not yet supported on any api (i contacted github support even). I originally was going to do a check where "has any of the owners in the list approved this PR", but since that isn't supported I would need to look for an LGTM comment or something

[cramforce]

Yes, lets do LGTM. I actually prefer that, because OWNERS may not have
rights to "Approve" changes.

On Mon, Oct 24, 2016 at 2:23 PM, erwin mombay [email protected]
wrote:

@cramforce https://github.com/cramforce the main issue im running into
is that the "approvals" endpoint or data is not yet supported on any api (i
contacted github support even). I originally was going to do a check where
"has any of the owners in the list approved this PR", but since that isn't
supported I would need to look for an LGTM comment or something

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5781 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFeT3CUrHte1_LiP90WAVsKumrhdSfuks5q3SHIgaJpZM4KfQLv
.

[erwinmombay]

@camelburrito can you suggest another owner for amp-carousel

[camelburrito]

add dima

[erwinmombay]

done

[erwinmombay]

@avimehta can you suggest another owner for amp-analytics

[avimehta]

dima is most familiar with the code after me.

[erwinmombay]

done

[erwinmombay]

wat.

[erwinmombay]

ah nevermind, my local env testing triggered an api call.

[jridgewell]

😭

[ampprojectbot]

Hi, ampproject bot here! Here are a list of the owners that can approve your files.

You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status

/to lannka zhouyx

• ads/OWNER.yaml

/to avimehta dvoytenko

• extensions/amp-analytics/OWNER.yaml

/to camelburrito dvoytenko

• extensions/amp-carousel/OWNER.yaml

/to aghassemi

• extensions/amp-form/OWNER.yaml

/to dvoytenko

• extensions/amp-google-vrview-image/OWNER.yaml

For any issues please file a bug at https://github.com/google/github-owners-bot/issues

[erwinmombay]

ok now thats gotta be a bug. review comment triggered a re-eval

[erwinmombay]

filed bug here google/github-owners-bot#24