Use more efficient string replacement and prevent validation errors from Interactivity API experiment #7694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelovekesh
approved these changes
Dec 18, 2023
|
Plugin builds for 4248179 are ready 🛎️!
ChecksumsWarning These builds are for testing purposes only and should not be used in production. |
thelovekesh
force-pushed
the
fix/efficient-string-replacement
branch
from
f3e90f2 to
1a2182f
Compare
westonruter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the string
AMP_MOBILE_REDIRECTIONonly occurs once in the JS file, there's no need for the more expensive regex match. A simple string replacement will suffice.This also fixes unit tests and prevents validation errors from being reported from scripts added by the Interactivity API experiment in Gutenberg.
This also fixes static analysis errors reported by PHPStan.