Fix navigation timeout errors in E2E tests #7669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelovekesh
force-pushed
the
fix/e2e-tests
branch
from
7bb0a5c to
36246a6
Compare
westonruter
reviewed
Nov 2, 2023
tests/e2e/puppeteer.config.js
Outdated
Comment on lines
9
to
20
| module.exports = { | ||
| launch: { | ||
| devtools: process.env.PUPPETEER_DEVTOOLS === 'true', | ||
| headless: process.env.PUPPETEER_HEADLESS !== 'false', | ||
| slowMo: parseInt(process.env.PUPPETEER_SLOWMO) || 0, | ||
| args: [ | ||
| '--enable-blink-features=ComputedAccessibilityInfo', | ||
| '--disable-web-security', | ||
| ], | ||
| executablePath: executablePath(), | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Where did you get this config from? If copied from somewhere, please include the link to the specific version of the config so it can be updated to reflect upstream changes.
There was a problem hiding this comment.
Now it will be automatically in sync with upstream - ee18f0a
| await deleteAllMenus(); | ||
| await createMenu( | ||
| { | ||
| name: 'Test Menu 1', | ||
| locations: [menuLocation], |
There was a problem hiding this comment.
So this makes the assignMenuToLocation function obsolete? It was doing additional work that wasn't needed?
There was a problem hiding this comment.
Yes, that's correct.
|
Plugin builds for ee18f0a are ready 🛎️!
ChecksumsWarning These builds are for testing purposes only and should not be used in production. |
thelovekesh
force-pushed
the
fix/e2e-tests
branch
2 times, most recently
from
4d59ace to
ee18f0a
Compare
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most of the time, E2E tests fail due to navigation timeout errors. Since we rely on
wp-scriptsfor running E2E tests, the package does not use the latest chromium for running the test suite hence causing so much flakiness in tests.Changes:
executablePath()puppeteer helper function in E2E tests.assignMenuToLocation()and updatecreateTestMenu()e2e util for adding menu locations.Checklist