Update allowed tags/attributes from spec in amphtml 2003031842100 #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
commented
Mar 15, 2020
| ), | ||
| 'tag_spec' => array( | ||
| 'mandatory_ancestor' => 'body', | ||
| 'mandatory_parent' => 'subscriptions-section content swg_amp_cache_nonce', |
There was a problem hiding this comment.
This looks like it is going to be problematic.
There was a problem hiding this comment.
Yes, it is. We can't currently add <script ciphertext type="application/octet-stream">...</script> inside of a section[subscriptions-section]. Will need to be addressed as part of #3817
| 'spec_name' => 'AMP-MEGA-MENU item-content', | ||
| ), | ||
| ), | ||
| 'AMP-MEGA-MENU item-heading' => array( |
There was a problem hiding this comment.
Problem: there is no item-heading element.
| 'spec_name' => 'AMP-MEGA-MENU NAV > UL/OL > LI', | ||
| ), | ||
| ), | ||
| 'AMP-MEGA-MENU item-content' => array( |
There was a problem hiding this comment.
Problem: there is no item-content element.
| 'spec_name' => 'AMP-MEGA-MENU NAV > UL/OL', | ||
| ), | ||
| ), | ||
| 'AMP-MEGA-MENU NAV > UL/OL > LI' => array( |
There was a problem hiding this comment.
The UL/OL will be a problem here.
| 'spec_name' => 'AMP-MEGA-MENU > NAV', | ||
| ), | ||
| ), | ||
| 'AMP-MEGA-MENU NAV > UL/OL' => array( |
There was a problem hiding this comment.
The UL/OL will be a problem here.
This was referenced Mar 17, 2020
…on amp-brid-player, link protocol/type
westonruter
force-pushed
the
update/amphtml-2003031842100
branch
from
535dddd to
da10be2
Compare
5 tasks
This reverts commit 7550879.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously #3619.
./bin/amphtml-update.sh(lando ssh -c 'bash ./bin/amphtml-update.sh vendor/amphtml')Changelog
amp-inline-gallery, includingamp-inline-gallery-paginationandamp-inline-gallery-thumbnails.amp-mega-menu.amp-nested-menu. Addedamp-nested-submenu-closeandamp-nested-submenu-openattributes to nestedbuttonelements, as well as adding attributes todiv,span, and each level of heading elements (h2–h6).chromeandfeed. Allowing type ofapplication/rss+xml.amp-story-page-attachmentandamp-story-grid-layer.amp-autocomplete, allowinginlineandqueryattributes, and makingfiltermandatory.docksupport toamp-brid-player.hide-keyboard-shortcuts-paneltoamp-date-picker.amp-list, removing[state]attribute and addingxssi-prefix.amp-next-page, adding attributes fordeep-parsingandmax-pages, and adding reference points.amp-redbull-player.intrinsiclayout toamp-script.amp-story-accesscomponent.next-page-no-adattribute toamp-story-page.amp-user-locationcomponent.input[type=button]element.script[type=text/plain][template=amp-mustache]to accept anidattribute.subscriptions script ciphertextandcryptokeys .json script.timeto allowpubdateattribute.next-page-hideandnext-page-replace.visible-when-invalidglobal attribute to addtooShortvalue.crossorigin=anonymousattribute toscriptandlinkelements. Will become the default with Add support for release channel(s) and crossorigin=anonymous scripts and links #4403.amp-mega-menu— note these do not currently enforce validation, as can be seen in the failing and now-reverted commit 7550879. Work will need to be done later to improve validation for reference points. The most important thing is that valid AMP is not being treated as invalid.AMP-MEGA-MENU > AMP-LISTAMP-MEGA-MENU > AMP-LIST > TEMPLATEAMP-MEGA-MENU > NAVAMP-MEGA-MENU NAV > UL/OLAMP-MEGA-MENU NAV > UL/OL > LIAMP-MEGA-MENU item-contentAMP-MEGA-MENU item-headingAMP-NEXT-PAGE > [footer]AMP-NEXT-PAGE > [recommendation-box]Details
( PREV_VERSION=1910161528000; THIS_VERSION=2003031842100; git checkout $THIS_VERSION; git diff $PREV_VERSION...$THIS_VERSION -w -- $( git ls-files | grep '.protoascii' ); git checkout - > /dev/null )Compare 1910161528000..2003031842100