Update Calling ReflectionProperty::setValue() with object

ampproject · Oct 6, 2023 · 0a0fae6 · 0a0fae6
1 parent 30736fe
commit 0a0fae6
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/tests/php/src/Helpers/PrivateAccess.php b/tests/php/src/Helpers/PrivateAccess.php
@@ -61,10 +61,7 @@ private function call_private_static_method( $class, $method_name, $args = [] )
 	private function set_private_property( $object, $property_name, $value ) {
 		$property = ( new ReflectionClass( $object ) )->getProperty( $property_name );
 		$property->setAccessible( true );
-
-		// Note: In PHP 8, `ReflectionProperty::getValue()` now requires that an object be supplied if it's a
-		// non-static property.
-		$property->isStatic() ? $property->setValue( $value ) : $property->setValue( $object, $value );
+		$property->setValue( $object, $value );
 	}
 
 	/**