Refactor build system and test runner since it no longer ran (#119)

ampproject · Jan 30, 2020 · 62909c6 · 62909c6
1 parent fbdd64c
commit 62909c6
Show file tree

Hide file tree

Showing 14 changed files with 4,513 additions and 12,904 deletions.
diff --git a/mobile-web/.babelrc b/mobile-web/.babelrc
@@ -1,11 +1,10 @@
 {
   "presets": [
-    ["env", {
+    ["@babel/preset-env", {
       "loose": true,
       "targets": {
-        "browsers": ["last 2 versions", "safari >= 7"]
-      },
-      "modules": "commonjs"
+        "browsers": ["last 2 versions", "safari >= 10"]
+      }
     }]
   ]
 }
diff --git a/mobile-web/.github/workflows/test.yml b/mobile-web/.github/workflows/test.yml
@@ -0,0 +1,19 @@
+name: Unit Tests
+
+on: [pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [12.x]
+    steps:
+    - uses: actions/checkout@v1
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v1
+      with:
+        node-version: ${{ matrix.node-version }}
+    - run: yarn install
+    - run: yarn build
+    - run: yarn test
diff --git a/mobile-web/README.md b/mobile-web/README.md
@@ -5,6 +5,7 @@
 
 | Command                                                                 | Description                                                           |
 | ----------------------------------------------------------------------- | --------------------------------------------------------------------- |
-| **`gulp`** | Runs "build" |
-| **`gulp serve`** or **`gulp watch`** | Runs "build" with watch and runs a localhost webserver |
-| **`gulp clean`** | deletes the /dist directory |
+| **`yarn build`** | Runs "build" |
+| **`yarn watch`** | Runs "build" with watch and runs a localhost webserver |
+| **`yarn test`** | executes tests in /tests directory |
+| **`yarn clean`** | deletes the /dist directory |
diff --git a/mobile-web/example/platform.html b/mobile-web/example/platform.html
@@ -5,7 +5,7 @@
   <title>Viewer</title>
   <meta name="viewport" content="width=device-width,initial-scale=1,minimum-scale=1,maximum-scale=1,user-scalable=no,minimal-ui">
   <link href='https://fonts.googleapis.com/css?family=Questrial' rel='stylesheet' type='text/css'>
-  <script src="../dist/viewer.js"></script>
+  <script src="viewer.js"></script>
   <style>
     html, body {
       overflow: hidden;

diff --git a/mobile-web/gulpfile.js b/mobile-web/gulpfile.js
diff --git a/mobile-web/karma.conf.js b/mobile-web/karma.conf.js
@@ -14,51 +14,47 @@
  * limitations under the License.
  */
 
+module.exports = function(config) {
+  config.set({
+    files: ["tests/**/*.js"],
 
-module.exports = {
+    frameworks: ["browserify", "chai", "mocha", "sinon-chai"],
 
-  files: ['tests/**/*.js'],
-
-  frameworks: [
-    'browserify',
-    'chai',
-    'mocha',
-    'sinon-chai',
-  ],
-
-  preprocessors: {
-    'src/**/*.js': ['browserify'],
-    'tests/**/*.js': ['browserify'],
-  },
-
-  browserify: {
-    watch: true,
-    debug: true,
-    transform: ['babelify'],
-    bundleDelay: 900,
-  },
-
-  port: 9876,
-  colors: true,
-  logLevel: process.env.TRAVIS ? 'ERROR' : 'WARN',
-  autoWatch: true,
-  browsers: [
-    process.env.TRAVIS ? 'Chrome_travis_ci' : 'Chrome_no_extensions',
-  ],
-
-  // Number of sauce tests to start in parallel
-  concurrency: 6,
-
-  customLaunchers: {
-    /*eslint "google-camelcase/google-camelcase": 0*/
-    Chrome_travis_ci: {
-      base: 'Chrome',
-      flags: ['--no-sandbox', '--disable-extensions'],
+    preprocessors: {
+      "src/**/*.js": ["browserify"],
+      "tests/**/*.js": ["browserify"]
     },
-    Chrome_no_extensions: {
-      base: 'Chrome',
-      // Dramatically speeds up iframe creation time.
-      flags: ['--disable-extensions'],
+
+    browserify: {
+      watch: true,
+      debug: true,
+      transform: ["babelify"],
+      bundleDelay: 900
     },
-  },
+
+    port: 9876,
+    colors: true,
+    logLevel: process.env.TRAVIS ? "ERROR" : "WARN",
+    autoWatch: true,
+    browsers: [
+      process.env.TRAVIS ? "Chrome_travis_ci" : "Chrome_no_extensions"
+    ],
+    singleRun: true,
+
+    // Number of sauce tests to start in parallel
+    concurrency: 6,
+
+    customLaunchers: {
+      /*eslint "google-camelcase/google-camelcase": 0*/
+      Chrome_travis_ci: {
+        base: "Chrome",
+        flags: ["--no-sandbox", "--disable-extensions"]
+      },
+      Chrome_no_extensions: {
+        base: "Chrome",
+        // Dramatically speeds up iframe creation time.
+        flags: ["--disable-extensions"]
+      }
+    }
+  });
 };