Skip to content

Improve PHP 8.4 compatibility #1260

Improve PHP 8.4 compatibility

Improve PHP 8.4 compatibility #1260

Triggered via pull request October 17, 2024 12:21
Status Failure
Total duration 1m 15s
Artifacts

test.yml

on: pull_request
Matrix: code-style
Matrix: static-analysis
Matrix: unit-test
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 27 warnings
Static analysis / PHP 8.0: src/Cli/AmpExecutable.php#L41
PHPDoc tag @var with type AmpProject\Cli\Command is not subtype of native type AmpProject\Cli\Command\Optimize|AmpProject\Cli\Command\Validate.
Static analysis / PHP 8.0: src/Cli/Options.php#L545
Call to function is_array() with array will always evaluate to true.
Static analysis / PHP 8.0: src/Cli/TableFormatter.php#L384
Call to function is_int() with int will always evaluate to true.
Static analysis / PHP 8.0: src/Cli/TableFormatter.php#L388
Call to function is_string() with string will always evaluate to true.
Static analysis / PHP 8.0: src/CssLength.php#L114
Offset 'numeral' on array{0: string, numeral: non-empty-string, 1: non-empty-string, unit?: 'em'|'px'|'rem'|'vh'|'vmax'|'vmin'|'vw', 2?: 'em'|'px'|'rem'|'vh'|'vmax'|'vmin'|'vw'} in isset() always exists and is not nullable.
Static analysis / PHP 8.0: src/Dom/Document.php#L383
Instanceof between AmpProject\Dom\Document\Filter and AmpProject\Dom\Document\Filter will always evaluate to true.
Static analysis / PHP 8.0: src/Dom/Document/Filter/DocumentEncoding.php#L129
Strict comparison using !== between string and false will always evaluate to true.
Static analysis / PHP 8.0: src/Dom/Document/Filter/MustacheScriptTemplates.php#L130
Call to an undefined method DOMNode::setAttribute().
Static analysis / PHP 8.0: src/Dom/Element.php#L80
Method AmpProject\Dom\Element::setAttribute() never returns false so it can be removed from the return type.
Static analysis / PHP 8.0: src/Dom/Element.php#L116
Instanceof between DOMAttr and DOMAttr will always evaluate to true.
Unit test (in random order) / PHP 8.2
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Unit test (in random order) / PHP 8.2
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit test (in random order) / PHP 8.2
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test / PHP 8.3
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Unit test / PHP 8.3
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit test / PHP 8.3
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test / PHP 8.4
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Unit test / PHP 8.4
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit test / PHP 8.4
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test (with coverage) / PHP 8.2
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, codecov/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Unit test (with coverage) / PHP 8.2
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2, codecov/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit test (with coverage) / PHP 8.2
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test / PHP 8.0
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Unit test / PHP 8.0
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit test / PHP 8.0
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test / PHP 8.1
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Unit test / PHP 8.1
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit test / PHP 8.1
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test / PHP 7.4
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Unit test / PHP 7.4
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit test / PHP 7.4
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Static analysis / PHP 8.0
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Static analysis / PHP 8.0
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Static analysis / PHP 8.0
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code style / PHP 7.4
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Code style / PHP 7.4
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Code style / PHP 7.4
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/