fix: also include NSURLErrorNotConnectedToInternet when setting configuration to offline #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guration to offline
thedavidharris
force-pushed
the
offline-retry-enhancement
branch
from
4725329 to
1b6626a
Compare
thedavidharris
changed the title
crleona
approved these changes
Dec 9, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
## [1.11.1](v1.11.0...v1.11.1) (2024-12-09) ### Bug Fixes * also include NSURLErrorNotConnectedToInternet when setting configuration to offline ([#249](#249)) ([4efb6f4](4efb6f4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Considers NSURLErrorNotConnectedToInternet as another case to set the SDK into offline mode. We were seeing a lot of errors of this type retried. Would have expected NWPathMonitor to pick this up but seems there's some other case where this can still happen, and it probably belongs in this list too.
Checklist