-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add CLI Support for Catalyst #337
base: sparkSql
Are you sure you want to change the base?
Conversation
chenghao-intel
commented
Jun 4, 2014
- Support reload the cachedRDD upon the start
- Support the CLI switch for Hive/Catalyst
@marmbrus Can you review that for me? Sorry, lots of code, but most of them are copied from the Shark. |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/Shark-Pull-Request-Builder/12203/ |
Still found some jar conflict issues, I will keep updating. |
Merged build triggered. |
Merged build started. |
SharkServer2Suite failed in my local test, seems the namespace conflict for the rewritten class CliService.java / HiveServer2.java, I will figure out how to fix that soon. Besides, I removed the cached RDD reload code for next PR. |
Merged build finished. |
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/Shark-Pull-Request-Builder/12204/ |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/Shark-Pull-Request-Builder/12205/ |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/Shark-Pull-Request-Builder/12206/ |
@chenghao-intel thanks for working on this. I think it is ok to not have the other features for now. We just need a CLI that we can use to query. |
The CLI is ready now, and it passed the unit test in my local (SharkServer2 doens't work in my local still), But Jenkins failed in retrieving the httpclient jar, @rxin , can you check that also in your local if possible? I am not sure if any env setting that only work for myself. |
Jenkins, retest this please. |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/Shark-Pull-Request-Builder/12207/ |
Still failed in retrieving the jar httpclient. |
Could it be missing a repository? |
Actually I 've added 3 more repository. |
I confirm that I can build this locally. @pwendell can we clear the .m2 / .ivy2 cache on the Jenkins machine? |
|
||
import shark.LogHelper | ||
|
||
//TODO work around for HiveContext, need to update that in Spark project (sql/hive), not here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think at least some of the issues that necessitate this class's existence have been fixed (e.g. EXPLAIN throwing exceptions). I'm fine with leaving these other fixes here for now, but can you file some JIRAs for the ones that aren't fixed in Spark?
@marmbrus , thanks for the comments. I will update the code accordingly. And the HiveContext issue was created at https://issues.apache.org/jira/browse/SPARK-2106. |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/Shark-Pull-Request-Builder/12208/ |
Hi @chenghao-intel thanks for working on this. Due to the failures in Jenkins, I've asked @liancheng to do more testing and update Shark based on this PR. He has started a new branch based on your work and will post an update soon. He might have some questions for you too. |