New version octoliner.js using new interface agreement #78
Conversation
modules/@amperka/octoliner.js
Outdated
| Octoliner.prototype.analogReadAll = function(analogArray) { | ||
| for (var i = 0; i < 8; i++) { | ||
| analogArray[i] = this.analogRead(i); | ||
| } |
There was a problem hiding this comment.
No reason to do this in JS. JavaScript memory is managed, so just create an array and return it.
Like (not checked):
var values = [0, 0, 0, 0, 0, 0, 0, 0];
for (var i = 0; i < 8; i++) {
values[i] = this.analogRead(i);
}
return values;There was a problem hiding this comment.
It is right. I am tryed to save the same interface.
There was a problem hiding this comment.
Done.
Do not forget to indicate the difference in the version of the API for JS.
modules/@amperka/octoliner.js
Outdated
| this.mapPatternToLine = this.defaultMapPatternToLine; | ||
| this.mapAnalogToPattern = this.defaultMapAnalogToPattern; |
There was a problem hiding this comment.
Why so? Just define mapPatternToLine, mapAnalogToPattern. A user may override them using regular prototypal JS-inheritance.
There was a problem hiding this comment.
It seems so clearer to me. I clearly indicate that this can be changed.
There was a problem hiding this comment.
This is not a native way for JS. It can confuse people who use JS in the JS-way. Suggest making the methods regular.
Co-Authored-By: Victor Nakoryakov <[email protected]>
|
@igor89, any feedback? |
New version octoliner.js using new API agreement.
API agreement you can look at: https://github.com/amperka/Octoliner/blob/V2/API.md