-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting, building and automated publishing #75
Conversation
Small update: only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Единственное что бросилось в глаза: перед открывающими фигурными скобками (if(){ /for() {/...) то вставляются пробелы то нет. По идее у преттификатора должна быть какая то однообразная интерпретация.
@yurybotov if и for должны отделяться пробелом однозначно. Не вижу, где без пробела? |
@igor89 review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A vast amount of changes introduced by replacing '
with "
. I think it is a wise idea to keep single quotes: we used them before here and we use single quotes in most other JS projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the libraries from the list. The change @knopki is OK. But during the test, errors were found in existing modules.
- Module
usb-keyboard.js
does not work on Windows OS. - Kit “Internet of Things (Yodo)” set in the examples, there is no check for an error connecting the Wi-Fi module to the access point. As a result, even if the module is not connected to the network, the code continues to work.
@nkrkv http://js.amperka.ru/emu/ Do we use it?
AFAIK no |
@nkrkv |
@igor89 Am I understand properly that Also, about |
That's right. Module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge
grunt
, custom nodejs http server,pm2
configuration removed..eslintrc
from upstream with some added globals. Some files edited to makeeslint
happy. @igor89 please test this files:Sim900r.js
(remove: unused callbacks, escape character)dweetio.js
(fix bug with always empty response)octoliner.js
(makei
shared)quaddisplay.js
(seeinterval
)usb-keyboard.js
(remove unused callbacks, makei
shared)wifi.js
(self
magic, useless function argument)x-fet.js
(makei
shared)prettier
initialized with empty config and all modules prettyfied. May be we need set some options forprettier
? (.prettierrc
needed even if empty to forcevscode
use empty config instead of defaults of extension)CircleCI automation:
@igor89 what is http://js.amperka.ru/emu/? If it used we can just put it to the GCS (already did) or publish source code as part of this repository.
@nkrkv @igor89 BTW Espruino supports URLs in
require
() (but I think example is broken because of wrong urls). So any module can be hosted fromgithub
without special repositories. Just to know.