Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Callback for Downloading #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

m42e
Copy link

@m42e m42e commented Jan 25, 2015

Added a optional callback for downloading. There is one parameter in the callback containing the size of the recently loaded chunk. The download initiator has to take care of the file size itself.

@chross
Copy link

chross commented Feb 12, 2018

When trying the following code, the callback is executed immediately and not only after the whole file is downloaded. Is this intended behaviour?

webdav.download(remote_path, local_path, unzip(local_path))

@m42e
Copy link
Author

m42e commented Feb 13, 2018

The callback is intended to give you an update while downloading so you can get the size of the downloaded chunk. So it is for progress, rather than completion. Just call unzip after the download call.

webdav.download(remote_path, local_path)
unzip(local_path)

@chross
Copy link

chross commented Feb 13, 2018

Thanks. Somehow I thought the download was threaded and working in the background (must have mixed that up with another webdav client I was testing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants