cleanup #78
Open
cleanup #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,7 +64,8 @@ public function __construct(ConfigFactoryInterface $config_factory) { | |||
| * @return bool | |||
| */ | |||
| public function isGroup($entity_type_id, $bundle) { | |||
| return isset($this->groupMap[$entity_type_id]) && in_array($bundle, $this->groupMap[$entity_type_id]); | |||
| $group_map = $this->groupMap(); | |||
There was a problem hiding this comment.
We had this like this originally, but removed it. It can come back though.
Can you please clarify what should go in the group repository - the name doesn't make it obvious for me. |
| } | ||
|
|
||
| /** | ||
| /** |
|
@chx is this still under your radar? :) |
|
I can look tomorrow, yes. |
@chx can you please clarify why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion with dawehner, I renamed GroupManager to GroupMap, introduced a group repository and simplified the OgAccessEntityTest a litte: no need to define a field any more.