-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CMakeLists.txt to support CPM #116
Conversation
Co-Authored-By: Claus Klein <[email protected]>
Great. |
Because symlinks on Windows require admin permission |
@ddalcino Could you test this change with Conan? I don't have many Conan projects to test this with |
I must be missing some context here. I'm not sure what you're asking for. I can test this manually with CMake Package Manager if that will help. As I understand it, CPM is the package manager that needs this change? Are you asking me to create a Conan package that uses project_options, and see if I can use it in a dependent project? That's probably a good idea, but I think it should be tested continuously rather than as a one-off. |
I tested under ubuntu this: https://github.com/ClausKlein/cpp_starter_project/commit/d690b81ec76351218bf8b08d52651fd2ceb3f474 |
I have tested this, and I can confirm that it works as intended. CI logs are here: https://github.com/ddalcino/cpp_starter_project/actions/runs/2072971834 For completeness, I have also verified that CPM does not load I think it could be really useful to add directions to the README about how to fetch |
Thanks for the testing! |
Co-Authored-By: @ClausKlein
Cherry-picked from #105