Linting run over once, pushing up for review. #3
Conversation
There was a problem hiding this comment.
@eawest2 there are still a couple sonarlint errors that can be fixed. Errors such as Swap these 2 arguments so they are in the correct order: expected value, actual value. in ConditionTest.java Everything else looks good.
| @@ -56,8 +56,8 @@ public static String generateIfNoneExist(BundleEntryComponent bundleEntry) { | |||
| // find any overriding OIDs. | |||
| String[] subsetOIDArray = getDefinedOIDs(bundleEntry.getResource().getResourceType().name()); | |||
|
|
|||
| if (bundleEntry.getResource().getResourceType().name() != "Medication" | |||
| && bundleEntry.getResource().getResourceType().name() != "PractitionerRole") { | |||
| if (bundleEntry.getResource().getResourceType().name().equals("Medication") == false | |||
There was a problem hiding this comment.
another way of doing this is if(!bundleEntry.getResource().getResourceType().name().equals("Medication"))
There was a problem hiding this comment.
Yeah. I mostly just wanted it to be explicit what the intent of the statement was without having to add comments to the code.
I'm not sure about those ones in |
What does this PR do?
Posting for Henry to check his codework against SONARlint
Related JIRA tickets:
SAR-47
How should this be manually tested?
Run the code through SONARlint, and run the tests.