Update to separate integration tests #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration tests require docker, which will be a problem if the build environment is also docker based. * Created a flag to indicate Integration tests * Added the flag to IntegrationTest.java * Updated pom.xml to have a separate integration-test goal * updated README.md * added mvnw to allow for easier execution without pre-installed maven
au2
requested changes
May 5, 2020
There was a problem hiding this comment.
- It is "integration-test" in pom so mvn integration-tests gives: [ERROR] Unknown lifecycle phase "integration-tests". Either correct pom or README; I think integration-tests is better.
- "mvn test" does not run the integration test but "mvn clean install" does. Isn't mvn clean install what you wanted to run inside a docker container?
- Not sure if you want to talk about ./mvnw in README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests require docker, which will be a problem if
the build environment is also docker based.
What does this PR do?
Related JIRA tickets:
How should this be manually tested?
Background/Context:
New JIRA tickets for clinical review required?