Interface redesign followups #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultimately it seems worth for the keyboard functionality. see pros/cons below. pros: - much easier to use with keyboard (see code comments) - opens upwards/downwards automatically based on space cons: - options don't look as stylish - is auto-sized based on all options width rather than the selected option... maybe we can override this in the future though.
can keep an eye on performance and undo if it's too slow
includes using square-rounding for toolbar buttons because it seems to fit better (way better for narrow menu buttons).
felt a little cramped
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ameliorate-docs canceled.
|
nice to have a quick way to hide the content overlays because they can sometimes be annoying. includes removing global body style because it seems that that isn't needed anymore?
bottom drawer didn't have enough space on the screen for small screens. also allows some code cleanup to not need to support a bottom/portrait drawer.
wasn't properly forwarding the `replace` prop via middleware. also enable (eslint) passing rest params because of this case.
replacing when we previously had a fewer-prop'd User Topic. need it for TopicForm to save api requests. doesn't seem like we need to avoid storing the small number of fields that exist on Topic anyway.
it's clearer and the whole user wasn't necessary
more convenient than going to a different page. includes fixing asymmetric Settings button hover effect because it didn't have right padding. this doesn't completely replace the new topic page because "start building" from the home page needs to route to a page, so that creating can start after the user logs in.
keyserj
force-pushed
the
interface-redesign-followups
branch
from
3f6dd5c to
70a2370
Compare
keyserj
force-pushed
the
interface-redesign-followups
branch
from
55ac4ef to
698313c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #617
Description of changes
Additional context