Create workspace overlay #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already was using bg-gray-50 for a background color that contrasts with paper, adding a theme color makes it more clear and standard.
to prepare for AppHeader, which will share some commonality with SiteHeader. includes: - extract Logo, SiteMenu, ProfileButton for reuse - move Docs link into SiteDrawer and hide on smaller screens (because there won't be as much space for it in the AppHeader)
also refactored the regex to handle more cases
it overlays & allows diagram to take more space for large screens
slash seemed like it had too much padding before this
i.e. specifically for the diagram and table overlayed for the diagram, in-line for the table, since the table is awkward to see some cells if there's any overlay. this feels more like a modern diagram UI. main driving factor was trying to make topic title & quick views more obvious to new users. includes making panes full height, see comment for explanation includes allowing Select and HelpMenu to be opened upwards when they're near bottom of screen - otherwise they'd open over the Select/Menu.
since they're less useful and more distracting for newer users also put details in left pane because it's still defaulting open and left feels better for a pane that'll be open most of the time?
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ameliorate-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #602
Description of changes
Additional context