Default indicators hidden #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even if editing, always showing these isn't necessary.
so that there's tailwind intellisense
going to revert this because it seems jarring when you hover something and it reveals something that's immediately hovered, e.g. hover edge -> hovering score. wanted to keep this commit in case it's valuable to refer back to the logic later.
because it seems jarring when you hover something and it reveals something that's immediately hovered, e.g. hover edge -> hovering score. keeping the change to use css instead of js for show/hiding because it seems a little cleaner; could consider js for performance improvements in the future (because it could prevent running rendering logic). also keeping diagram-node/-edge classes because they seem probably useful in the future.
having indicators off makes the diagram much easier to read, and new users won't know how to use indicators right away anyway. will want to make sure zen mode is pointed out early in tutorial though, so users can still take advantage of indicators when they become useful to them.
because with new diagrams, it commonly results in pretty spread out diagrams, trying to avoid crossings for long problem-solution edges. it also sometimes creates poor left-to-right ordering within a layer.
it's clearer about what it does.
This was annoying to do because of the reasons below, but since we're defaulting indicators to hidden, we have to ensure docs mention it (since users would otherwise be confused when getting to "scores" in the docs). I think the button name is slightly suboptimal because: - Score is more interactive than just an Indicator Also these docs updates are a little suboptimal because: - the button is only explained in the Scoring section; hopefully users can understand its use for the indicator section, but it seems annoying to duplicate the explanation there too. It's possible that "show scores" should be a separate button, but: - both would often be on/off together - both would need separate tutorial/docs mentions?
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ameliorate-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #478
Description of changes
Additional context