Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCB] Make AWS XRay/EMF Exporters available as individual modules directly from amazon-contributing #248

Closed

Conversation

jj22ee
Copy link

@jj22ee jj22ee commented Oct 30, 2024

Description:

Main Changes:
For the following components, make them available as go modules specifically from the amazon-contributing repository fork of opentelemetry-collector-contrib:

exporter/awsxrayexporter/
exporter/awsemfexporter/

// Internal dependencies of above modules
internal/aws/xray/
internal/aws/metrics/
internal/aws/cwlogs/
internal/aws/awsutil/

The involves changing:

  • from: module github.com/open-telemetry/opentelemetry-collector-contrib/...
  • to: module github.com/amazon-contributing/opentelemetry-collector-contrib/...

Additional Changes:

  1. Change version of github.com/amazon-contributing/opentelemetry-collector-contrib/override/awsfromv0.0.0-00010101000000-000000000000tov0.0.0-20241024160840-0c7076070f12in allgo.mod` files
  2. Remove dependency on internal/coreinternal. This involves copying:
    • const value opencensusAttributeExporterVersion = "opencensus.exporterversion"
    • function spanIDToHexOrEmptyString(id pcommon.SpanID)

Link to tracking Issue:

Testing:

  1. Run go test ./... in all 6 modified modules.
  2. Build OTel Collector via OCB with these components from jj22ee repository
  3. To test downloading the modules from amazon-contributing/opentelemetry-collector-contrib, this can only happen after the PR is merged, so it will be tested then.

Documentation:

@jj22ee jj22ee changed the title Make AWS XRay/EMF Exporters available as individual modules directly from amazon-contributing [OCB] Make AWS XRay/EMF Exporters available as individual modules directly from amazon-contributing Oct 31, 2024
@jj22ee jj22ee closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants