[internal/aws] Update AWS clients to allow for configured request handlers. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefchien
changed the title
mitali-salvi
previously approved these changes
Oct 20, 2023
JayPolanco
previously approved these changes
Oct 20, 2023
jefchien
dismissed stale reviews from JayPolanco and mitali-salvi
via
c88233e
Add middleware ID to config and configure during exporter startup.
jefchien
force-pushed
the
update-client
branch
from
c88233e to
34f76b6
Compare
JayPolanco
approved these changes
Oct 20, 2023
mitali-salvi
approved these changes
Oct 20, 2023
lisguo
pushed a commit
to lisguo/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add middleware ID to config and added/modified
Startfunction to try to configure the middleware. Made this change forawscloudwatchlogsexporter,awsemfexporter, andawsxrayexporter.Update the clients to expose the AWS client
request.Handlers. Slightly modified some exporters to enable middleware attachment on startup.Link to tracking Issue: N/A
Testing: Added unit tests.
Documentation: N/A