SendMessageReceipt Update + Adding GitHub README #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrajatttt
reviewed
Oct 10, 2024
mliao95
force-pushed
the
mikeliao/documentation-update
branch
from
96d50cd to
568db6b
Compare
mliao95
changed the title
mrajatttt
reviewed
Oct 11, 2024
| } | ||
| // Check if the transcript item is a plain text message, is not empty, and is incoming | ||
| if (messageItem == null || messageItem.text.isEmpty() || messageItem.participant == "CUSTOMER") { | ||
| return@withContext Result.failure<Boolean>(IllegalArgumentException("Invalid message item. Cannot send message receipts for outgoing or empty messages.")) |
There was a problem hiding this comment.
Do we need to do this? It might spam logs
There was a problem hiding this comment.
I think it should be fine. I don't think the empty message or null message path will be hit very much. It would only spam if they are sending message receipts for all end customer messages, and it would make sense for us to surface an exception instead of the customer wondering why a message receipt wasn't sent.
mrajatttt
approved these changes
Oct 12, 2024
haomingli2020
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Description:
What are the changes? Why are we making them?
Changing return type of
sendMessageReceiptto beResult<Boolean>to match the other SDK APIs.GitHub README update
Testing: