setting up the repository #1
Conversation
|
Looks like GitHub Actions is having trouble running unit tests |
Yes, this will fail until we setup the julia sim (and the registry) so it can be pulled in as a dependency of this repo. |
|
Can we re-trigger CI here now that the registry is set up? |
I think I need to add a script to reference the new registry, no? |
Co-authored-by: Abe Coull <[email protected]>
| **/braket/default_simulator/openqasm/parser/generated/* | ||
| **/braket/device_schema/** | ||
| **/braket/ir/** | ||
| **/braket/task_result/** |
There was a problem hiding this comment.
Do we need items such as:
**/braket/simulator/*
*/site-packages/braket/*
?
There was a problem hiding this comment.
Not yet. We might refine this list, but I'd like to understand how running the tests in this simulator overlaps with the functionality we use from the default sim.
src/braket/simulator_v2/simulator.py
Outdated
| r.resultTypes = results | ||
| return r | ||
|
|
||
| """A simulator meant to run directly on the user's machine using a Julia backend. |
There was a problem hiding this comment.
This comment seems misplaced.
| @property | ||
| def properties(self) -> GateModelSimulatorDeviceCapabilities: | ||
| observables = ["x", "y", "z", "h", "i", "hermitian"] | ||
| max_shots = sys.maxsize |
There was a problem hiding this comment.
Why do we set this to maxsize?
There was a problem hiding this comment.
Because the number of shots can be anything
Co-authored-by: Abe Coull <[email protected]>
Co-authored-by: Abe Coull <[email protected]>
Co-authored-by: Abe Coull <[email protected]>
Co-authored-by: Abe Coull <[email protected]>
|
The coverage output still looks incorrect |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.