This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Support URL with Hash based routing #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should support URL with hash based routing, the has isn't stands for query params and shouldn't be parsed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #87
Description of changes:
parseCognitoWebResponseassumes tjat hashes are always stand for query parameters, and didn't take into considuration that this may be just hash based routing.add another paramter to indicate the difference.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.