Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: migrate from eslint/prettier to biome #18

Merged
merged 2 commits into from
Jul 29, 2024
Merged

ci: migrate from eslint/prettier to biome #18

merged 2 commits into from
Jul 29, 2024

Conversation

amandaguthrie
Copy link
Owner

@amandaguthrie amandaguthrie commented Jul 29, 2024 •
edited
Loading

🪄 Changes

> Internal

Migrate from ESLint and Prettier to BiomeJS.

  • Format type imports to comply with new rules
  • Format forEach to for ... of loops
  • Format != undefined -> != null or !== undefined

📪 Closes Issues

None

✅ Quality Checklist

> 🟢 All Pull Requests

  • Tests updated?
  • Test snapshot generation is turned off?
  • Documentation updated?
  • Changesets added/updated?
  • Checks passing (eslint, prettier, Typescript, unit tests)?

@amandaguthrie amandaguthrie merged commit 69d7ddf into main Jul 29, 2024
3 checks passed
@amandaguthrie amandaguthrie deleted the ci/biome-migration branch July 29, 2024 21:07
@amandaguthrie amandaguthrie mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amandaguthrie