Spark rapids tools 1120 fea args #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayed Bilal Bari <[email protected]>
Signed-off-by: Sayed Bilal Bari <[email protected]>
Signed-off-by: Sayed Bilal Bari <[email protected]>
Signed-off-by: Sayed Bilal Bari <[email protected]>
amahussein
reviewed
Jul 2, 2024
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkArgs.scala
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/QualificationBenchmark.scala
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/QualificationBenchmark.scala
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkBase.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkArgs.scala
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkArgs.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkArgs.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkArgs.scala
Outdated
Show resolved
Hide resolved
| default = Some("."), descr = "Directory to write output to") | ||
|
|
||
| val outputFormat: ScallopOption[String] = opt[String](name = "outputFormat", short = 'o', | ||
| default = Some("tbl"), descr = "Format of output ( tbl, json)") |
There was a problem hiding this comment.
- More details about the options and what each one of them mean.
- Suggest changing "tbl" to "text"
- the short version 'o' should be for the outputDirectory. For this option, "'f'" would be more suitable
- QQ why do we specify the name in all the options? shouldn't Scallop do that automatically?
There was a problem hiding this comment.
- Added more description
- Changed tbl to text. Current PR does not do any processing on output format. Later iteration will merge the JSON output changes
- The short formats have been updated
- The name option is just for verbosity. Saw online implementation using name param hence added it
There was a problem hiding this comment.
I belive if we leave it without name then scalaOpt will automatically convert the variable name.
For example, outputDirectory becomes output-directory
It will be better to use the snake-case because the tools main classes are following that standard. QualificationMain and ProfilingMain
There was a problem hiding this comment.
Removed the name param to enable snake-case usage in params
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/Benchmark.scala
Outdated
Show resolved
Hide resolved
amahussein
reviewed
Jul 2, 2024
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/QualificationBenchmark.scala
Show resolved
Hide resolved
| warmUpIterations = warmUpIterations, | ||
| minNumIters = iterations) | ||
| benchmarker.addCase("QualificationBenchmark") { _ => | ||
| mainInternal(new QualificationArgs(mainArgs), |
There was a problem hiding this comment.
I am little bit confused here. If we initialize QualificationArgs on line 21, then what are those default arguments that are passed to the benchmarker variable?
There was a problem hiding this comment.
Clarified post discussion. Benchmarker arguments control iterations and warm up iterations. The passed ffunction to the benchmarker is what is benchmarked internally
There was a problem hiding this comment.
We will iterate on this later.
Signed-off-by: Sayed Bilal Bari <[email protected]>
bilalbari
commented
Jul 2, 2024
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/Benchmark.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkArgs.scala
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkArgs.scala
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkArgs.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkArgs.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkBase.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/QualificationBenchmark.scala
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/QualificationBenchmark.scala
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/QualificationBenchmark.scala
Show resolved
Hide resolved
| warmUpIterations = warmUpIterations, | ||
| minNumIters = iterations) | ||
| benchmarker.addCase("QualificationBenchmark") { _ => | ||
| mainInternal(new QualificationArgs(mainArgs), |
There was a problem hiding this comment.
Clarified post discussion. Benchmarker arguments control iterations and warm up iterations. The passed ffunction to the benchmarker is what is benchmarked internally
amahussein
reviewed
Jul 2, 2024
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkArgs.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkBase.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/QualificationBenchmark.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkBase.scala
Outdated
Show resolved
Hide resolved
| warmUpIterations = warmUpIterations, | ||
| minNumIters = iterations) | ||
| benchmarker.addCase("QualificationBenchmark") { _ => | ||
| mainInternal(new QualificationArgs(mainArgs), |
There was a problem hiding this comment.
We will iterate on this later.
Signed-off-by: Sayed Bilal Bari <[email protected]>
bilalbari
commented
Jul 2, 2024
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkArgs.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/BenchmarkBase.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/rapids/tool/benchmarks/QualificationBenchmark.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Sayed Bilal Bari <[email protected]>
amahussein
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.