Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify node version retrieval #206

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

darseen
Copy link
Contributor

@darseen darseen commented Jan 8, 2024

Simplify Node Version Retrieval

Changes Made

  • Updated the method for fetching Node.js version in the codebase.
  • Replaced the usage of process.version and manual removal of 'v' with process.versions.node.

Impact

This change improves code readability and eliminates the need for additional string manipulation, making the codebase cleaner and more straightforward.

Motivation

The current implementation involves fetching the Node.js version using process.version and then manually removing the 'v' character. This pull request simplifies the process by directly utilizing process.versions.node to obtain the Node.js version without the 'v' character.

Test

No functional changes have been made; this is a refactoring to enhance code simplicity.

Checklist

  • Updated Node.js version retrieval to use process.versions.node.
  • Ensured backward compatibility and no functional changes.
  • Tested the code to ensure it functions as expected.

Additional Information

  • No breaking changes expected.

@minjikarin minjikarin self-requested a review January 10, 2024 13:13
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@minjikarin
Copy link
Contributor

minjikarin commented Jan 10, 2024

Thank you again so much for contribution @darseen ! :) amazing!

confirmed no impact on the API request

@minjikarin minjikarin merged commit 3aba7d3 into amadeus4dev:master Jan 10, 2024
4 checks passed
@darseen darseen deleted the node-version-retrieval branch January 15, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants