Merge pull request #204 from Darseen/initOptional-refactor

Simplify initOptional function for clarity
amadeus4dev · Jan 3, 2024 · a70fd98 · a70fd98
2 parents b3efb5f + fdea4a7
commit a70fd98
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/src/amadeus/client/validator.js b/src/amadeus/client/validator.js
@@ -80,12 +80,9 @@ class Validator {
   }
 
   initOptional(key, options, fallback = null) {
-    let value = options[key];
     //Env variables names expected to be in SNAKE_CASE and uppercase
     let envKey = `AMADEUS_${key.replace(/[A-Z]/g, c => `_${c.toLowerCase()}`).toUpperCase()}`;
-    if (value == undefined) { value = options[key]; }
-    if (value == undefined) { value = process.env[envKey]; }
-    if (value == undefined) { value = fallback; }
+    let value = options[key] || process.env[envKey] || fallback;
     return value;
   }