mark isRoofOpened and setRoofOpened as deprecated

Former-commit-id: eeba229
altmp · Dec 19, 2020 · b7c0a2c · b7c0a2c
1 parent c5fd4cd
commit b7c0a2c
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 2 deletions.
diff --git a/src/bindings/Vehicle.cpp b/src/bindings/Vehicle.cpp
@@ -175,6 +175,10 @@ extern V8Class v8Vehicle("Vehicle", v8Entity, Constructor, [](v8::Local<v8::Func
 	proto->SetAccessor(v8::String::NewFromUtf8(isolate, "daylightOn"), &DaylightOnGetter);
 	proto->SetAccessor(v8::String::NewFromUtf8(isolate, "nightlightOn"), &NightlightOnGetter);
 	proto->SetAccessor(v8::String::NewFromUtf8(isolate, "roofState"), &RoofStateGetter, &RoofStateSetter);
+
+	proto->Set(v8::String::NewFromUtf8(isolate, "isRoofOpened"), v8::FunctionTemplate::New(isolate, &IsRoofOpenedDeprecated));
+	proto->Set(v8::String::NewFromUtf8(isolate, "setRoofOpened"), v8::FunctionTemplate::New(isolate, &SetRoofOpenedDeprecated));
+
 	proto->SetAccessor(v8::String::NewFromUtf8(isolate, "flamethrowerActive"), &FlamethrowerActiveGetter);
 	proto->SetAccessor(v8::String::NewFromUtf8(isolate, "activeRadioStation"), &ActiveRadioStationGetter, &ActiveRadioStationSetter);
 	proto->SetAccessor(v8::String::NewFromUtf8(isolate, "lightsMultiplier"), &LightsMultiplierGetter, &LightsMultiplierSetter);

diff --git a/src/bindings/vehicle/GameState.h b/src/bindings/vehicle/GameState.h
@@ -209,7 +209,7 @@ namespace V8::Vehicle
 
 		Ref<IVehicle> vehicle = _this->GetHandle().As<IVehicle>();
 
-		info.GetReturnValue().Set(v8::Boolean::New(isolate, vehicle->GetRoofState()));
+		info.GetReturnValue().Set(v8::Integer::New(isolate, vehicle->GetRoofState()));
 	}
 
 	void RoofStateSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
@@ -224,7 +224,39 @@ namespace V8::Vehicle
 
 		Ref<IVehicle> vehicle = _this->GetHandle().As<IVehicle>();
 
-		vehicle->SetRoofState(value->ToBoolean(info.GetIsolate())->Value());
+		vehicle->SetRoofState(value->ToInteger(info.GetIsolate())->Value());
+	}
+
+	void IsRoofOpenedDeprecated(const v8::FunctionCallbackInfo<v8::Value>& info)
+	{
+		v8::Isolate* isolate = info.GetIsolate();
+
+		V8ResourceImpl* resource = V8ResourceImpl::Get(isolate->GetEnteredContext());
+		V8_CHECK(resource, "invalid resource");
+
+		V8Entity* _this = V8Entity::Get(info.This());
+		V8_CHECK(_this, "entity is invalid");
+
+		Ref<IVehicle> vehicle = _this->GetHandle().As<IVehicle>();
+
+		info.GetReturnValue().Set(v8::Boolean::New(isolate, vehicle->GetRoofState()));
+	}
+
+	void SetRoofOpenedDeprecated(const v8::FunctionCallbackInfo<v8::Value>& info)
+	{
+		v8::Isolate* isolate = info.GetIsolate();
+
+		V8_CHECK(info.Length() == 1, "1 arg expected");
+
+		V8ResourceImpl* resource = V8ResourceImpl::Get(isolate->GetEnteredContext());
+		V8_CHECK(resource, "invalid resource");
+
+		V8Entity* _this = V8Entity::Get(info.This());
+		V8_CHECK(_this, "entity is invalid");
+
+		Ref<IVehicle> vehicle = _this->GetHandle().As<IVehicle>();
+
+		vehicle->SetRoofState(info[0]->ToInteger(isolate)->Value());
 	}
 
 	void FlamethrowerActiveGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)