Merge pull request #69 from ZackaryH8/vector-constructor

shared: Add constructor overload to Vector class Former-commit-id: 3bbe4a6
altmp · Oct 17, 2021 · 9cb2966 · 9cb2966
2 parents 8e1172e + 260bb2e
commit 9cb2966
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/shared/bindings/Vector2.cpp b/shared/bindings/Vector2.cpp
@@ -616,6 +616,11 @@ static void Constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
             V8_CHECK(x->IsNumber(), "x must be a number");
             V8_CHECK(y->IsNumber(), "y must be a number");
         }
+        else if(val->IsNumber())
+        {
+            x = val;
+            y = val;
+        }
         else
         {
             V8Helpers::Throw(isolate, "Argument must be an array of 2 numbers or IVector2");

diff --git a/shared/bindings/Vector3.cpp b/shared/bindings/Vector3.cpp
@@ -739,6 +739,12 @@ static void Constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
             V8_CHECK(y->IsNumber(), "y must be a number");
             V8_CHECK(z->IsNumber(), "z must be a number");
         }
+        else if(val->IsNumber())
+        {
+            x = val;
+            y = val;
+            z = val;
+        }
         else
         {
             V8Helpers::Throw(isolate, "Argument must be an array of 3 numbers or IVector3");