ALTV-380 Remove nodejs binary suffix

altmp · Oct 1, 2024 · 082cad9 · 082cad9
1 parent 38f3f11
commit 082cad9
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/build-deploy.yml b/.github/workflows/build-deploy.yml
@@ -85,7 +85,7 @@ jobs:
           cd server
           mkdir -p upload/modules/js-module
           cp ./dist/libjs-module.so ./upload/modules/js-module
-          cp ./dist/libnode.so.108 ./upload/modules/js-module
+          cp ./dist/libnode.so ./upload/modules/js-module
           echo ${{ steps.version.outputs.SDK_COMMIT }} >> ./upload/sdk.version
 
       - uses: actions/upload-artifact@v3

diff --git a/docs/troubleshooting.md b/docs/troubleshooting.md
@@ -11,7 +11,7 @@ Add a C++ file to your project with following content and include it in the  `so
 
 extern "C" NODE_EXTERN void node_module_register(void* mod)
 {
-    auto base_ptr = dlopen("libnode.so.108", RTLD_NOW | RTLD_GLOBAL);
+    auto base_ptr = dlopen("libnode.so", RTLD_NOW | RTLD_GLOBAL);
     if (base_ptr == nullptr) return;
     auto register_func = reinterpret_cast<decltype(&node_module_register)>(dlsym(base_ptr, "node_module_register"));
     if (register_func == nullptr) return;

diff --git a/server/CMakeLists.txt b/server/CMakeLists.txt
@@ -158,5 +158,5 @@ if (WIN32)
 endif (WIN32)
 
 if (UNIX)
-  target_link_libraries(${PROJECT_NAME} ${PROJECT_SOURCE_DIR}/deps/nodejs/lib/libnode.so.108)
+  target_link_libraries(${PROJECT_NAME} ${PROJECT_SOURCE_DIR}/deps/nodejs/lib/libnode.so)
 endif (UNIX)
diff --git a/server/build.sh b/server/build.sh
@@ -16,4 +16,4 @@ if [ ! -d "./dist" ]; then
     mkdir dist
 fi
 cp ./build-linux/libjs-module.so dist
-cp ./deps/nodejs/lib/libnode.so.108 dist
+cp ./deps/nodejs/lib/libnode.so dist
diff --git a/server/cmake/DepsDownload.cmake b/server/cmake/DepsDownload.cmake
@@ -33,7 +33,7 @@ function(DownloadDeps)
 
             GetCDNInfo("${__deps_url_base_path}" __deps_linux_hashes __deps_current_version)
 
-            DownloadFile("libnode.so.108" "${__base_path}" "" ${__deps_linux_hashes})
+            DownloadFile("libnode.so" "${__base_path}" "" ${__deps_linux_hashes})
         endif()
 
         message("NodeJS deps version: ${NODEJS_VERSION}")