fix(server): Add missing .all and getByID for VirtualEntityGroup

altmp · Mar 7, 2024 · d32c361 · d32c361
1 parent 052c8ec
commit d32c361
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/server/js/entity.js b/server/js/entity.js
@@ -2,3 +2,4 @@
 const { addAllGetter } = requireBinding("shared/entity.js");
 
 addAllGetter(alt.VoiceChannel, alt.Enums.BaseObjectType.VOICE_CHANNEL);
+addAllGetter(alt.VirtualEntityGroup, alt.Enums.BaseObjectType.VIRTUAL_ENTITY_GROUP);
diff --git a/server/src/classes/VirtualEntityGroup.cpp b/server/src/classes/VirtualEntityGroup.cpp
@@ -6,4 +6,6 @@ extern js::Class sharedVirtualEntityGroupClass;
 extern js::Class virtualEntityGroupClass("VirtualEntityGroup", &sharedVirtualEntityGroupClass, nullptr, [](js::ClassTemplate& tpl)
 {
     tpl.BindToType(alt::IBaseObject::Type::VIRTUAL_ENTITY_GROUP);
+
+    tpl.GetByID<alt::IBaseObject::Type::VIRTUAL_ENTITY_GROUP>();
 });
diff --git a/types/server/index.d.ts b/types/server/index.d.ts
@@ -768,13 +768,17 @@ declare module "@altv/server" {
     export abstract class VirtualEntityGroup extends BaseObject {
         readonly maxEntitiesInStream: number;
 
+        static readonly all: ReadonlyArray<VirtualEntityGroup>;
+
         public onCreate?(opts: altShared.VirtualEntityGroupCreateOptions): void;
         public onDestroy?(): void;
 
         static create(opts: altShared.VirtualEntityGroupCreateOptions): VirtualEntityGroup;
 
         static setFactory(factory: typeof VirtualEntityGroup): void;
         static getFactory<T extends VirtualEntityGroup>(): T;
+
+        static getByID(id: number): VirtualEntityGroup | null;
     }
 
     export abstract class VirtualEntity extends WorldObject {

diff --git a/types/server/package.json b/types/server/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@altv/server",
-    "version": "0.0.36",
+    "version": "0.0.37",
     "description": "This package contains the type definitions for the alt:V JS module v2 server types",
     "types": "index.d.ts",
     "files": [
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,3 +2,4 @@
		const { addAllGetter } = requireBinding("shared/entity.js");

		addAllGetter(alt.VoiceChannel, alt.Enums.BaseObjectType.VOICE_CHANNEL);
		addAllGetter(alt.VirtualEntityGroup, alt.Enums.BaseObjectType.VIRTUAL_ENTITY_GROUP);