shared: add Vector3::cross typings (#142)

altmp · Oct 30, 2023 · 5ff7b9d · 5ff7b9d
1 parent ce5d446
commit 5ff7b9d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/shared/js/classes/vector.js b/shared/js/classes/vector.js
@@ -175,8 +175,8 @@ export class Vector3 extends Vector {
         return this.values[2];
     }
 
-    cross(vectorOrX, y, z) {
-        const vec = vectorOrX instanceof Vector ? vectorOrX : new Vector3(vectorOrX, y, z);
+    cross(...args) {
+        const vec = new Vector3(...args);
         return new this.constructor(this.y * vec.z - this.z * vec.y, this.z * vec.x - this.x * vec.z, this.x * vec.y - this.y * vec.x);
     }
 

diff --git a/types/shared/index.d.ts b/types/shared/index.d.ts
@@ -308,6 +308,12 @@ declare module "@altv/shared" {
         dot(xyz: IVector3): Vector3;
         dot(xyz: number): Vector3;
 
+        cross(x: number, y: number, z: number): Vector3;
+        cross(other: Vector3): Vector3;
+        cross(xyz: [number, number, number]): Vector3;
+        cross(xyz: IVector3): Vector3;
+        cross(xyz: number): Vector3;
+
         distanceTo(x: number, y: number, z: number): number;
         distanceTo(other: Vector3): number;
         distanceTo(xyz: [number, number, number]): number;