fix(shared): Fix BigInts not being parsed properly

altmp · Feb 15, 2024 · 05d9152 · 05d9152
1 parent c24bead
commit 05d9152
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 8 deletions.
diff --git a/server/src/classes/Metric.cpp b/server/src/classes/Metric.cpp
@@ -38,7 +38,7 @@ static void ValueSetter(js::PropertyContext& ctx)
     if(!ctx.CheckExtraInternalFieldValue()) return;
     alt::Metric* metric = ctx.GetExtraInternalFieldValue<alt::Metric>();
 
-    uint32_t value;
+    uint64_t value;
     if(!ctx.GetValue(value)) return;
 
     metric->SetValue(value);
@@ -65,7 +65,7 @@ static void Add(js::FunctionContext& ctx)
     if(!ctx.CheckExtraInternalFieldValue()) return;
     alt::Metric* metric = ctx.GetExtraInternalFieldValue<alt::Metric>();
 
-    uint32_t value;
+    uint64_t value;
     if(!ctx.GetArg(0, value)) return;
 
     metric->Add(value);

diff --git a/shared/src/helpers/Convert.h b/shared/src/helpers/Convert.h
@@ -311,12 +311,26 @@ namespace js
         else if constexpr(std::is_same_v<T, int64_t> || std::is_same_v<T, uint64_t>)
         {
             constexpr bool isSigned = std::is_same_v<T, int64_t>;
-            v8::Local<v8::BigInt> bigInt;
-            v8::MaybeLocal<v8::BigInt> maybeBigInt = val->ToBigInt(v8::Isolate::GetCurrent()->GetEnteredOrMicrotaskContext());
-            if(!maybeBigInt.ToLocal(&bigInt)) return std::nullopt;
-            if constexpr(isSigned) return bigInt->Int64Value();
-            else
-                return bigInt->Uint64Value();
+
+            if (val->IsBigInt())
+            {
+                v8::Local<v8::BigInt> bigInt;
+                v8::MaybeLocal<v8::BigInt> maybeBigInt = val->ToBigInt(v8::Isolate::GetCurrent()->GetEnteredOrMicrotaskContext());
+                if(!maybeBigInt.ToLocal(&bigInt)) return std::nullopt;
+
+                if constexpr(isSigned)
+                    return bigInt->Int64Value();
+                else
+                    return bigInt->Uint64Value();
+            }
+
+            using Type = std::conditional_t<isSigned, int32_t, uint32_t>;
+            const auto _val = CppValue<Type>(val);
+
+            if (_val.has_value())
+            {
+                return static_cast<T>(_val.value());
+            }
         }
         else if constexpr(std::is_integral_v<T> || std::is_floating_point_v<T> || std::is_enum_v<T>)
         {