Add config options for exit routing overhaul #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch starts the exit routing overhal patch series with config changes. Namely making the exit configuration expressive enough to descirbe all of the target behaviors.
jkilpatr
force-pushed
the
jkilpatr/exit-cgnat
branch
4 times, most recently
from
fbf8052 to
063e765
Compare
jkilpatr
force-pushed
the
jkilpatr/exit-cgnat
branch
3 times, most recently
from
a5d5612 to
7f324ae
Compare
This patch simplifies the dataflow for the rita exit module by removing the lazy static exit database and instead holding that data in the main rita exit thread. In the multi-exit test this actually separates the exit databases for the first time (they previously shared a single lazy static).
jkilpatr
force-pushed
the
jkilpatr/exit-cgnat
branch
4 times, most recently
from
a2dc82d to
bfb8119
Compare
This patch adds the external ip assigment code. Design wise we're keeping the internal subnet and simply exiting traffic at these specific ip later on.
This patch modifies the internal ip assignment and ipv6 address assignment to match in design and test coverage with the external ip assignment code. This simplification is mostly achived by removing the requirement that clients get the same ip each time they connect even between reboots. Reviewing the code I decided it was easier to fix that problem on the rita_client side than to deal with the solution here.
jkilpatr
force-pushed
the
jkilpatr/exit-cgnat
branch
from
bfb8119 to
4a77b84
Compare
This patch removes handling code for wg_exit and wg_exit_v2 as distinct interfaces. This code for handling legacy routers (beta 19 and earlier) is no longer relevant as we're breaking compatibility with everything up until beta 23 (this branch) anyways.
Since the exit registration smart contract does not store data about the client wireguard listen port it exists only as a constant. Before this patch it was two constants one in the exit code and one in the client. It's not strictly required to set the client listen port correctly, the server listen port is passed through the registration contract and is sufficient to generate a handshake. But obviously there's no reason to have two constants for the same value around. The issue that actually generated errors was in the integration test, where the wg_exit listen port for smart contract registration was hardcoded indepenently of the default value in the rita_exit settings. By unifying these constants a confusing integration test error is no longer possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch starts the exit routing overhal patch series with config changes. Namely making the exit configuration expressive enough to descirbe all of the target behaviors.