[mme] handle second s1ap setup as reset #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencersevilla
added a commit
that referenced
this pull request
Jan 17, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 24, 2024
spencersevilla
added a commit
that referenced
this pull request
Jan 25, 2024
spencersevilla
added a commit
that referenced
this pull request
Mar 7, 2024
spencersevilla
added a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per T.S. 136.413.8.7.3.1, If the MME receives an S1AP SetupRequest from an eNB it is already associated with, it must handle the SetupRequest as though the eNB sent it a S1 Reset message, and clear all associated enb contexts. This is an issue we've seen in our networks after short network disconnects. Note that the eNB also plays by these rules, and has already reset itself and "forgotten" all UEs by the time it sends the SetupRequest.
Also, note that we are using the OGS_GTP_RELEASE_S1_CONTEXT_REMOVE_BY_LO_CONNREFUSED codepath and not REMOVE_BY_RESET_ALL because they are all very similar. The key difference is RESET_ALL keeps track and waits until all s11 replies have been received by the sgwc, and then sends a ResetAcknowledge message. We have no such constraint so we just delete all the sessions immediately and move on.