Skip to content
This repository has been archived by the owner on Sep 9, 2023. It is now read-only.

Commit

Permalink
general: fixing test flakiness
Browse files Browse the repository at this point in the history
  • Loading branch information
@bmancini55
bmancini55 committed Mar 27, 2019
1 parent 160a66f commit de45694
Show file tree
Hide file tree
Showing 21 changed files with 1,559 additions and 1,738 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
"license": "MIT",
"main": "src/index.js",
"scripts": {
"test": "jest --testEnvironment=node --testRunner=jest-circus/runner --coverage",
"test:ci": "jest --testEnvironment=node --testRunner=jest-circus/runner --coverage && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js"
"test": "jest --testEnvironment=node --testRunner=jest-circus/runner --coverage --testPathPattern=src\/.+\\.spec\\.js --maxWorkers=32",
"test:ci": "jest --testEnvironment=node --testRunner=jest-circus/runner --coverage --testPathPattern=src\/.+\\.spec\\.js --maxWorkers=32 && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js"
},
"repository": "altangent/ccxws",
"dependencies": {
Expand Down
254 changes: 126 additions & 128 deletions src/exchanges/binance-client.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,69 +9,68 @@ let market = {
quote: "BTC",
};

beforeAll(() => {
client = new Binance();
});
describe("BinanceClient", () => {
beforeAll(() => {
client = new Binance();
});

test("it should support tickers", () => {
expect(client.hasTickers).toBeTruthy();
});
test("it should support tickers", () => {
expect(client.hasTickers).toBeTruthy();
});

test("it should support trades", () => {
expect(client.hasTrades).toBeTruthy();
});
test("it should support trades", () => {
expect(client.hasTrades).toBeTruthy();
});

test("it should support level2 snapshots", () => {
expect(client.hasLevel2Snapshots).toBeTruthy();
});
test("it should support level2 snapshots", () => {
expect(client.hasLevel2Snapshots).toBeTruthy();
});

test("it should support level2 updates", () => {
expect(client.hasLevel2Updates).toBeTruthy();
});
test("it should support level2 updates", () => {
expect(client.hasLevel2Updates).toBeTruthy();
});

test("it should not support level3 snapshots", () => {
expect(client.hasLevel3Snapshots).toBeFalsy();
});
test("it should not support level3 snapshots", () => {
expect(client.hasLevel3Snapshots).toBeFalsy();
});

test("it should not support level3 updates", () => {
expect(client.hasLevel3Updates).toBeFalsy();
});
test("it should not support level3 updates", () => {
expect(client.hasLevel3Updates).toBeFalsy();
});

test("should subscribe and emit ticker events", done => {
client.subscribeTicker(market);
client.on("ticker", ticker => {
expect(ticker.fullId).toMatch("Binance:ETH/BTC");
expect(ticker.timestamp).toBeGreaterThan(1531677480465);
expect(typeof ticker.last).toBe("string");
expect(typeof ticker.open).toBe("string");
expect(typeof ticker.high).toBe("string");
expect(typeof ticker.low).toBe("string");
expect(typeof ticker.volume).toBe("string");
expect(typeof ticker.change).toBe("string");
expect(typeof ticker.changePercent).toBe("string");
expect(typeof ticker.bid).toBe("string");
expect(typeof ticker.bidVolume).toBe("string");
expect(typeof ticker.ask).toBe("string");
expect(typeof ticker.askVolume).toBe("string");
expect(parseFloat(ticker.last)).toBeGreaterThan(0);
expect(parseFloat(ticker.open)).toBeGreaterThan(0);
expect(parseFloat(ticker.high)).toBeGreaterThan(0);
expect(parseFloat(ticker.low)).toBeGreaterThan(0);
expect(parseFloat(ticker.volume)).toBeGreaterThan(0);
expect(parseFloat(ticker.quoteVolume)).toBeGreaterThan(0);
expect(isNaN(parseFloat(ticker.change))).toBeFalsy();
expect(isNaN(parseFloat(ticker.changePercent))).toBeFalsy();
expect(parseFloat(ticker.bid)).toBeGreaterThan(0);
expect(parseFloat(ticker.bidVolume)).toBeGreaterThan(0);
expect(parseFloat(ticker.ask)).toBeGreaterThan(0);
expect(parseFloat(ticker.askVolume)).toBeGreaterThan(0);
done();
test("should subscribe and emit ticker events", done => {
client.subscribeTicker(market);
client.on("ticker", ticker => {
expect(ticker.fullId).toMatch("Binance:ETH/BTC");
expect(ticker.timestamp).toBeGreaterThan(1531677480465);
expect(typeof ticker.last).toBe("string");
expect(typeof ticker.open).toBe("string");
expect(typeof ticker.high).toBe("string");
expect(typeof ticker.low).toBe("string");
expect(typeof ticker.volume).toBe("string");
expect(typeof ticker.change).toBe("string");
expect(typeof ticker.changePercent).toBe("string");
expect(typeof ticker.bid).toBe("string");
expect(typeof ticker.bidVolume).toBe("string");
expect(typeof ticker.ask).toBe("string");
expect(typeof ticker.askVolume).toBe("string");
expect(parseFloat(ticker.last)).toBeGreaterThan(0);
expect(parseFloat(ticker.open)).toBeGreaterThan(0);
expect(parseFloat(ticker.high)).toBeGreaterThan(0);
expect(parseFloat(ticker.low)).toBeGreaterThan(0);
expect(parseFloat(ticker.volume)).toBeGreaterThan(0);
expect(parseFloat(ticker.quoteVolume)).toBeGreaterThan(0);
expect(isNaN(parseFloat(ticker.change))).toBeFalsy();
expect(isNaN(parseFloat(ticker.changePercent))).toBeFalsy();
expect(parseFloat(ticker.bid)).toBeGreaterThan(0);
expect(parseFloat(ticker.bidVolume)).toBeGreaterThan(0);
expect(parseFloat(ticker.ask)).toBeGreaterThan(0);
expect(parseFloat(ticker.askVolume)).toBeGreaterThan(0);
done();
});
});
});

test(
"should subscribe and emit trade events",
done => {
test("should subscribe and emit trade events", done => {
client.subscribeTrades(market);
client.on("trade", trade => {
expect(trade.fullId).toMatch("Binance:ETH/BTC");
Expand All @@ -87,86 +86,85 @@ test(
expect(parseFloat(trade.amount)).toBeGreaterThan(0);
done();
});
},
30000
);

test("should subscribe and emit level2 updates", done => {
let hasSnapshot = false;
let hasUpdates = false;
client.subscribeLevel2Updates(market);
client.on("l2snapshot", snapshot => {
hasSnapshot = true;
expect(snapshot.fullId).toMatch("Binance:ETH/BTC");
expect(snapshot.exchange).toMatch("Binance");
expect(snapshot.base).toMatch("ETH");
expect(snapshot.quote).toMatch("BTC");
expect(snapshot.sequenceId).toBeGreaterThan(0);
expect(snapshot.timestampMs).toBeUndefined();
expect(parseFloat(snapshot.asks[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(snapshot.asks[0].size)).toBeGreaterThanOrEqual(0);
expect(snapshot.asks[0].count).toBeUndefined();
expect(parseFloat(snapshot.bids[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(snapshot.bids[0].size)).toBeGreaterThanOrEqual(0);
expect(snapshot.bids[0].count).toBeUndefined();
if (hasSnapshot && hasUpdates) done();
});
client.on("l2update", update => {
hasUpdates = true;
expect(update.fullId).toMatch("Binance:ETH/BTC");
expect(update.exchange).toMatch("Binance");
expect(update.base).toMatch("ETH");
expect(update.quote).toMatch("BTC");
expect(update.sequenceId).toBeGreaterThan(0);
expect(update.lastSequenceId).toBeGreaterThanOrEqual(update.sequenceId);
if (update.asks.length) {
expect(parseFloat(update.asks[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(update.asks[0].size)).toBeGreaterThanOrEqual(0);
}
if (update.bids.length) {
expect(parseFloat(update.bids[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(update.bids[0].size)).toBeGreaterThanOrEqual(0);
}
if (hasSnapshot && hasUpdates) done();
}, 30000);

test("should subscribe and emit level2 updates", done => {
let hasSnapshot = false;
let hasUpdates = false;
client.subscribeLevel2Updates(market);
client.on("l2snapshot", snapshot => {
hasSnapshot = true;
expect(snapshot.fullId).toMatch("Binance:ETH/BTC");
expect(snapshot.exchange).toMatch("Binance");
expect(snapshot.base).toMatch("ETH");
expect(snapshot.quote).toMatch("BTC");
expect(snapshot.sequenceId).toBeGreaterThan(0);
expect(snapshot.timestampMs).toBeUndefined();
expect(parseFloat(snapshot.asks[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(snapshot.asks[0].size)).toBeGreaterThanOrEqual(0);
expect(snapshot.asks[0].count).toBeUndefined();
expect(parseFloat(snapshot.bids[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(snapshot.bids[0].size)).toBeGreaterThanOrEqual(0);
expect(snapshot.bids[0].count).toBeUndefined();
if (hasSnapshot && hasUpdates) done();
});
client.on("l2update", update => {
hasUpdates = true;
expect(update.fullId).toMatch("Binance:ETH/BTC");
expect(update.exchange).toMatch("Binance");
expect(update.base).toMatch("ETH");
expect(update.quote).toMatch("BTC");
expect(update.sequenceId).toBeGreaterThan(0);
expect(update.lastSequenceId).toBeGreaterThanOrEqual(update.sequenceId);
if (update.asks.length) {
expect(parseFloat(update.asks[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(update.asks[0].size)).toBeGreaterThanOrEqual(0);
}
if (update.bids.length) {
expect(parseFloat(update.bids[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(update.bids[0].size)).toBeGreaterThanOrEqual(0);
}
if (hasSnapshot && hasUpdates) done();
});
});
});

test("should subscribe and emit level2 snapshots", done => {
client.subscribeLevel2Snapshots(market);
client.on("l2snapshot", snapshot => {
expect(snapshot.fullId).toMatch("Binance:ETH/BTC");
expect(snapshot.exchange).toMatch("Binance");
expect(snapshot.base).toMatch("ETH");
expect(snapshot.quote).toMatch("BTC");
expect(snapshot.sequenceId).toBeGreaterThan(0);
expect(snapshot.timestampMs).toBeUndefined();
expect(parseFloat(snapshot.asks[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(snapshot.asks[0].size)).toBeGreaterThanOrEqual(0);
expect(snapshot.asks[0].count).toBeUndefined();
expect(parseFloat(snapshot.bids[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(snapshot.bids[0].size)).toBeGreaterThanOrEqual(0);
expect(snapshot.bids[0].count).toBeUndefined();
done();
test("should subscribe and emit level2 snapshots", done => {
client.subscribeLevel2Snapshots(market);
client.on("l2snapshot", snapshot => {
expect(snapshot.fullId).toMatch("Binance:ETH/BTC");
expect(snapshot.exchange).toMatch("Binance");
expect(snapshot.base).toMatch("ETH");
expect(snapshot.quote).toMatch("BTC");
expect(snapshot.sequenceId).toBeGreaterThan(0);
expect(snapshot.timestampMs).toBeUndefined();
expect(parseFloat(snapshot.asks[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(snapshot.asks[0].size)).toBeGreaterThanOrEqual(0);
expect(snapshot.asks[0].count).toBeUndefined();
expect(parseFloat(snapshot.bids[0].price)).toBeGreaterThanOrEqual(0);
expect(parseFloat(snapshot.bids[0].size)).toBeGreaterThanOrEqual(0);
expect(snapshot.bids[0].count).toBeUndefined();
done();
});
});
});

test("should unsubscribe from tickers", () => {
client.unsubscribeTicker(market);
});
test("should unsubscribe from tickers", () => {
client.unsubscribeTicker(market);
});

test("should unsubscribe from trades", () => {
client.unsubscribeTrades(market);
});
test("should unsubscribe from trades", () => {
client.unsubscribeTrades(market);
});

test("should unsubscribe from level2 snapshots", () => {
client.unsubscribeLevel2Snapshots(market);
});
test("should unsubscribe from level2 snapshots", () => {
client.unsubscribeLevel2Snapshots(market);
});

test("should unsubscribe from level2 updates", () => {
client.unsubscribeLevel2Updates(market);
});
test("should unsubscribe from level2 updates", () => {
client.unsubscribeLevel2Updates(market);
});

test("should close connections", done => {
client.on("closed", done);
client.close();
test("should close connections", done => {
client.on("closed", done);
client.close();
});
});
Loading

0 comments on commit de45694

Please sign in to comment.