Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Align viewer with altair repo #49

Closed

Conversation

mattijn
Copy link
Member

@mattijn mattijn commented Jan 13, 2022

This PR:

  • align the INLINE_HTML variable with the current Altair repo counterpart

Copy link
Member

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this? We don't have any automated test coverage of javascript rendering, so it will be important to test manually.

In particular, I'm concerned about the removal of the code that strips js from the paths when running under requirejs. Are you certain that's no longer necessary?

@mattijn
Copy link
Member Author

mattijn commented Jan 14, 2022

I've tested locally, but I can understand if we want to test this more scrupulously in different environments.

@joelostblom
Copy link
Member

Since Altair 5.3, the functionality of Altair Viewer is now available in Altair via the vl-convert package instead. See the docs on how to use the browser renderer to display charts via .show(), and the PR vega/altair#3379 for more details.

We are going to archive this repo, so I'm closing all the open issues and PRs before doing so. Try out the new options for rendering charts mentioned above and if you run into issues, please open an issue directly in the altair or vl-convert repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants