Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] GroupByVerb parameter and behaviours. #166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

homotechsual
Copy link

@homotechsual homotechsual commented Jul 22, 2023

This adds a -GroupByVerb parameter and associated functionality including:

  • Splits the markdown files into subfolders by approved PowerShell verb.
  • Alters folder cleaning to recurse into the verb folders (but doesn't remove the folders yet)
  • Alters sidebar generation to reflect the subfolder structure.
  • Changes some existing simple array generation to [System.Collections.Generic.List[]] for speed and ease of collection population.

Discussion points:

  1. Should it remove empty verb folders if found when cleaning? (I would like this to happen - but would like wider input.)
  2. Any fundamental changes to this approach you'd like to see?
  3. Test plan?

@vercel
Copy link

vercel bot commented Jul 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docusaurus-powershell ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 10:43pm

@homotechsual homotechsual changed the title [WIPAdd GroupByVerb parameter and behaviours. [WIP] GroupByVerb parameter and behaviours. Jul 22, 2023
@bravo-kernel
Copy link
Contributor

Thanks for putting this up here, I will take a look into it when I find some time. Refs #129.

@homotechsual
Copy link
Author

It's in use on https://dev.homotechsualdocs.pages.dev/ for the HaloAPI and NinjaOne modules.

@bravo-kernel
Copy link
Contributor

Apologies for the delay, I needed to fix the CI pipeline first. Could you please rebase against main and let me know so we can start the test suite? After that, we will take it from there.

@homotechsual
Copy link
Author

Sure - I also have a couple more tweaks I've made from using this "in anger" that I'll fold in :-)

@homotechsual
Copy link
Author

Might be a week or so though!

@bravo-kernel
Copy link
Contributor

No worries, take your time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants